Great script! We are currently using it on our production Nagios servers.
We did have one small problem though. After a few days we ended up with about 70G of error logs resulting from two lines of the code.
/var/log/apache/error.log:
[Mon Mar 28 14:27:27 2011] [error] [client xxx.xxx.xxx.xxx] PHP Notice:
Undefined offset: 0 in /var/www/dashboard/nagios_get.php on line 208,
referer: nagios.lcsee.wvu.edu/dashboard/
[Mon Mar 28 14:27:27 2011] [error] [client xxx.xxx.xxx.xxx] PHP Notice:
Undefined offset: 0 in /var/www/dashboard/nagios_get.php on line 224,
referer: nagios.lcsee.wvu.edu/dashboard/
We are actually using the modified version from dingleberry.me (Thanks to them as well) so the line numbers don’t match up but the offending lines are:
if ($servicearray$servicecount] != “”) { //if the host has a service being checked
and
if ($servicearray$servicecount] == “”) { //if the host has no service being checked
The problem is we have a few entities which don’t have services (used as parents) so $servicearray[0] isn’t a valid array index at the point of those evaluations.
To remedy the problem I added an ‘else’ to an earlier evaluation which determines if there are any services. If there are no services then it sets $servicearray[0]="".
The code follows.
Original:
if ($servicepos !== false) {
$servicecount++;
$servicearray$servicecount] = substr($line, strpos($line, ‘=’) + 1, strlen($line));
$check = 1;
}
Modified:
if ($servicepos !== false) {
$servicecount++;
$servicearray$servicecount] = substr($line, strpos($line, ‘=’) + 1, strlen($line));
$check = 1;
} else {
$servicearray[0] = “”;
}
Fairly simple fix but I hope this can help someone in the future.
Thanks again for the great script!
